Conversation
matthewruehle
left a comment
matthewruehle
left a comment
There was a problem hiding this comment.
All in all, a reasonable revision off of the text mining project. Your original was definitely not the cleanest, but this has removed unnecessary code/repetition and packaged everything up into some functions. The functions themselves have less-than-formal names, and not a ton of documentation; unfortunately, cleanliness/coding practices were one of the focuses of the mini project. Still, solid revisions; you chose a good direction for MP5!
| return markovdict | ||
|
|
||
|
|
||
| def smushit(markovdict, megalist): |
There was a problem hiding this comment.
Could use a bit more by way of documentation. You've cleaned up the script/jumbles into clean functions, but it's not immediately clear what the functions themselves do.
| return " ".join(finallist) | ||
|
|
||
|
|
||
| def main_important_part(): |
There was a problem hiding this comment.
FWIW, not the ideal name, but it gets the point across!
| """ | ||
| megalist = [] | ||
| markovdict = {} | ||
| # print("in global scope", id(markovdict)) |
2 participants
No description provided.